netdev - Re: [PATCH v2] ibm_newemac: Fixes entry of short packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <486E14E3.6080402@garzik.org>
Date:	Fri, 04 Jul 2008 08:17:39 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Stefan Roese <sr@...x.de>
CC:	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	benh@...nel.crashing.org, Sathya Narayanan <sathyan@...mf1.com>
Subject: Re: [PATCH v2] ibm_newemac: Fixes entry of short packets

Stefan Roese wrote:
> From: Sathya Narayanan <sathyan@...mf1.com>
> 
> Short packets has to be discarded by the driver. So this patch addresses the
> issue of discarding the short packets of size lesser then ethernet header
> size.
> 
> Signed-off-by: Sathya Narayanan <sathyan@...mf1.com>
> Signed-off-by: Stefan Roese <sr@...x.de>
> ---
>  drivers/net/ibm_newemac/core.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index ca63fa0..babc79a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -1636,6 +1636,12 @@ static int emac_poll_rx(void *param, int budget)
>  			goto next;
>  		}
>  
> +		if (len < ETH_HLEN) {
> +			++dev->estats.rx_dropped_stack;
> +			emac_recycle_rx_skb(dev, slot, len);
> +			goto next;
> +		}
> +
>  		if (len && len < EMAC_RX_COPY_THRESH) {

applied 2.6.26


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html