netdev - Re: [PATCH net-next 3/9] ipv4: remove static flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080708.030559.209246943.davem@davemloft.net>
Date:	Tue, 08 Jul 2008 03:05:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	containers@...ts.osdl.org, netdev@...r.kernel.org,
	ebiederm@...ssion.com
Subject: Re: [PATCH net-next 3/9] ipv4: remove static flush_delay variable

From: "Denis V. Lunev" <den@...nvz.org>
Date: Mon, 07 Jul 2008 15:26:14 +0400

> On Mon, 2008-07-07 at 01:43 -0700, Eric W. Biederman wrote:
> > "Denis V. Lunev" <den@...nvz.org> writes:
> > 
> > > flush delay is used as an external storage for net.ipv4.route.flush sysctl
> > > entry. It is write-only.
> > >
> > > The ctl_table->data for this entry is used once. Fix this case to point
> > > to the stack to remove global variable. Do this to avoid additional
> > > variable on struct net in the next patch.
> > >
> > > Possible race (as it was before) accessing this local variable is removed
> > > using flush_mutex.
> > 
> > FYI.  You can avoid the locking entirely by defining a local struct ctl_table variable
> > on the stack.
> 
> Dave, could you consider the patch attached?

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html