netdev - Re: [PATCH net-next 3/9] ipv4: remove static flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1215429974.29879.84.camel@iris.sw.ru>
Date:	Mon, 07 Jul 2008 15:26:14 +0400
From:	"Denis V. Lunev" <den@...nvz.org>
To:	David Miller <davem@...emloft.net>
Cc:	containers@...ts.osdl.org, netdev@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH net-next 3/9] ipv4: remove static flush_delay variable

On Mon, 2008-07-07 at 01:43 -0700, Eric W. Biederman wrote:
> "Denis V. Lunev" <den@...nvz.org> writes:
> 
> > flush delay is used as an external storage for net.ipv4.route.flush sysctl
> > entry. It is write-only.
> >
> > The ctl_table->data for this entry is used once. Fix this case to point
> > to the stack to remove global variable. Do this to avoid additional
> > variable on struct net in the next patch.
> >
> > Possible race (as it was before) accessing this local variable is removed
> > using flush_mutex.
> 
> FYI.  You can avoid the locking entirely by defining a local struct ctl_table variable
> on the stack.

Dave, could you consider the patch attached?

Download attachment "0001-ipv4-remove-flush_mutex-from-ipv4_sysctl_rtcache_fl.patch" of type "application/mbox" (1539 bytes)