[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 07 Jul 2008 13:22:04 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Wang Chen <wangchen@...fujitsu.com>
CC: "David S. Miller" <davem@...emloft.net>,
NETDEV <netdev@...r.kernel.org>
Subject: Re: v3 [PATCH net-next 5/7] ipv4: Check return of dev_set_allmulti
Wang Chen wrote:
> case VIFF_TUNNEL:
> dev = ipmr_new_tunnel(vifc);
> if (!dev)
> return -ENOBUFS;
> + err = dev_set_allmulti(dev, 1);
> + if (err) {
> + dev_close(dev);
> + return err;
> + }
ipmr_new_tunnel creates a new tunnel device that you're not removing.
> break;
> case 0:
> dev = ip_dev_find(&init_net, vifc->vifc_lcl_addr.s_addr);
> if (!dev)
> return -EADDRNOTAVAIL;
> dev_put(dev);
> + err = dev_set_allmulti(dev, 1);
> + if (err)
> + return err;
Also looks like a use after free, but again, one that is
already present without your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists