netdev - Re: Printing the driver name as part of the netdev watchdog message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080708.145738.12692130.davem@davemloft.net>
Date:	Tue, 08 Jul 2008 14:57:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arjan@...radead.org
Cc:	swise@...ngridcomputing.com, rdreier@...co.com,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message

From: Arjan van de Ven <arjan@...radead.org>
Date: Tue, 8 Jul 2008 14:47:25 -0700

> On Tue, 08 Jul 2008 14:31:58 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
> > From: Steve Wise <swise@...ngridcomputing.com>
> > Date: Tue, 08 Jul 2008 14:13:43 -0500
> > 
> > > So should I put the rtnl acquisitions back in iw_cxgb3?  Or fix
> > > cxgb3 to not assume rtnl is held?
> > 
> > It appears that the kernel always invokes the ethtool ops with
> > RTNL held, and therefore that's the environment that needs
> > to be ensured.
> 
> so for the patch that started all this... do I need to go back to the
> original where I didn't use ethool?
> (since this is called from irq context....)

What we need instead is to cache the info block into the netdev struct
when the driver is ->open()'d, and then you can fetch it out of
there however you like.

Or, at least, that is one possible approach.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html