netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080709164619.GA26098@orion.carnet.hr>
Date:	Wed, 9 Jul 2008 18:46:19 +0200
From:	Josip Rodin <joy@...ian.org>
To:	Michael Chan <mchan@...adcom.com>
Cc:	'Bill Fink' <billfink@...dspring.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	netdev <netdev@...r.kernel.org>,
	"mirrors@...ian.org" <mirrors@...ian.org>
Subject: Re: bnx2_poll panicking kernel

On Thu, Jun 26, 2008 at 11:04:48AM -0700, Michael Chan wrote:
> Josip Rodin wrote:
> > 
> > Here we go, this is the first batch of debug output. I hope it helps.
> > 
> 
> Thanks for the data.  I've looked at a few of these SKB dumps and they
> appear to be all modified in the same way:
> 
> 1. SKB is unchanged and the clone bit is set.
> 
> 2. skb_shared_info(SKB) has dataref 0x00010002 and these fields are
> changed:
> 
>    nr_frags changed from n to 1
>    gso_size changed from 0x5a8 to 0
>    gso_type changed from 1 (TCP_V4) to 0
>    gso_segs changed from m to 1
>    1 of the frags' length is modified to split the TSO packet into 1
> segment
> 
> I think this is consistent with what David said about tso_fragment()
> splitting the cloned TSO SKB into 2.

Okay, thanks, can you tell me if the previous patch is a proper fix or just
a workaround?

Recently we've been seeing rsync errors with some of the sites which used to
be pretty fast - the connection unexpectedly closes, or it times out.
Something is still fishy about it...

-- 
Josip Rodin
mirrors@...ian.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html