[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080709115010.388b7b1c@infradead.org>
Date: Wed, 9 Jul 2008 11:50:10 -0700
From: Arjan van de Ven <arjan@...radead.org>
To: Joe Perches <joe@...ches.com>
Cc: Stephen Hemminger <stephen.hemminger@...tta.com>,
David Miller <davem@...emloft.net>,
swise@...ngridcomputing.com, rdreier@...co.com,
shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message
On Wed, 09 Jul 2008 11:20:49 -0700
Joe Perches <joe@...ches.com> wrote:
> On Wed, 2008-07-09 at 10:56 -0700, Arjan van de Ven wrote:
> > I don't like the size_t... size_t is an abstraction to deal with
> > file sizes.... but there's nothing else wrong with using an int for
> > numbers.
>
> <pedant_mode>
>
> o size_t is an abstraction to deal with arbitrary sizes
it's an int. abstractions hurt. sorry.
> o an unnecessary <= 0 test exists
it's not. if it was a < test going to an unsigned makes the test go
away, but it's a <=.
And signed actually catches more bugs because unsigned makes things
silent.
--
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists