netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080710.140016.171249048.davem@davemloft.net>
Date:	Thu, 10 Jul 2008 14:00:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	joy@...ian.org, billfink@...dspring.com, bhutchings@...arflare.com,
	netdev@...r.kernel.org, mirrors@...ian.org
Subject: Re: bnx2_poll panicking kernel

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 10 Jul 2008 14:00:17 -0700

> On Wed, 2008-07-09 at 16:46 -0700, David Miller wrote:
> > Actually I went investigating this and all the code paths check for
> > skb_cloned() and if true they make a copy of the data area (and thus
> > the skb_shared_info()) and this should ensure that the driver doesn't
> > see changing nr_frags values.
> 
> Since Josip can readily reproduce this problem, let's confirm if the SKB
> is split while it is cloned.  Please try this debug patch:

Another good place to check would be __pskb_trim_head() in
net/ipv4/tcp_output.c but the skb_cloned() check in one of that
function's only callers (tcp_trim_head) is rather explicit :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html