netdev - Re: [PATCH net-next-2.6 v4 2/2] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080715135244.17106mgc64fxlpj4@hayate.ip6>
Date:	Tue, 15 Jul 2008 13:52:44 +0300
From:	"Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 v4 2/2] hfsc: add link layer overhead
	adaption

Quoting "Patrick McHardy" <kaber@...sh.net>:

>
> I thought you were going to make this a generic qdisc feature.
> Why is configuration still qdisc specific?
>

I was thinking keeping scope of this patch within hfsc, as done with  
rest of rate table qdiscs. So it would be better to have they all to  
use generic size table instead of duplicating rtab code.

> I was thinking of something like this:
>
> - add generic attributes for configuring size tables for any
>   qdisc, handle those in sch_api
>
> - add qdisc_enqueue() wrapper that calculates the size and
>   stores it in skb->cb, convert direct calls of sch->enqueue
>   to use it
>
> - change direct uses of skb->len to use the size from the cb
>
> The second step might need a bit more thought to make sure
> qdiscs don't get confused when the dequeued packet is larger
> than the enqueued one, but I think they usually don't care.
>

I guess I'll start over using your size table patch as base then.

  - Jussi



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html