netdev - Re: [PATCH net-next-2.6 v4 2/2] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080714.221125.137630059.davem@davemloft.net>
Date:	Mon, 14 Jul 2008 22:11:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	jussi.kivilinna@...et.fi, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 v4 2/2] hfsc: add link layer overhead
 adaption

From: Patrick McHardy <kaber@...sh.net>
Date: Mon, 14 Jul 2008 16:24:41 +0200

> I thought you were going to make this a generic qdisc feature.
> Why is configuration still qdisc specific?
> 
> I was thinking of something like this:
> 
> - add generic attributes for configuring size tables for any
>    qdisc, handle those in sch_api
> 
> - add qdisc_enqueue() wrapper that calculates the size and
>    stores it in skb->cb, convert direct calls of sch->enqueue
>    to use it
> 
> - change direct uses of skb->len to use the size from the cb
> 
> The second step might need a bit more thought to make sure
> qdiscs don't get confused when the dequeued packet is larger
> than the enqueued one, but I think they usually don't care.

This sounds sane.

After having to edit every damn file net/sched/ over the weekend
a few things really bugged me.  One of which was how so much logic
is duplicated in the configuration support code.

The worst offender is TCA_RATE, it's scattered all over the place.

If I get ambitious after all the multiqueue bits are sorted I might
try to consolidate some of this stuff.

But definitely, let's not add more of that kind of stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html