netdev - Re: [PATCH RFC 07/10] mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080715134003.GV19302@solarflare.com>
Date:	Tue, 15 Jul 2008 14:40:05 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il,
	Roland Dreier <rdreier@...co.com>
Subject: Re: [PATCH RFC 07/10] mlx4_en: Rx flow

Yevgeny Petrilin wrote:
[...]
> +static int mlx4_en_prepare_rx_desc(struct mlx4_en_priv *priv,
> +				   struct mlx4_en_rx_ring *ring, int index)
> +{
> +	struct mlx4_en_rx_desc *rx_desc = ring->buf + (index * ring->stride);
> +	struct skb_frag_struct *skb_frags = ring->rx_info +
> +					    (index << priv->log_rx_info);
> +	int i;
> +
> +	PREFETCH((void *) rx_desc + L1_CACHE_BYTES);
> +	PREFETCH((void *) skb_frags + L1_CACHE_BYTES);
[...]

You should use the standard prefetch() macro, not your own.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html