netdev - Re: [PATCH RFC 07/10] mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080715142722.GX19302@solarflare.com>
Date:	Tue, 15 Jul 2008 15:27:24 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il,
	Roland Dreier <rdreier@...co.com>
Subject: Re: [PATCH RFC 07/10] mlx4_en: Rx flow

Yevgeny Petrilin wrote:
[...]
> +int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int budget)
> +{
[...]
> +		if (likely(priv->rx_csum)) {
> +			if ((cqe->flags_h & MLX4_EN_BIT_IPOK) &&
> +			    (cqe->chksum == 0xffff)) {
> +				/* This packet is eligible for LRO if it is:
> +				 * - DIX Ethernet (type interpretation)
> +				 * - TCP/IP (v4)
> +				 * - without IP options
> +				 * - not an IP fragment */
> +				if ((*((__be32 *) &cqe->flags_h) &
> +				     cpu_to_be32(TCPIP_MASK_32)) ==
> +				     cpu_to_be32(LRO_MASK_32)) {
[...]

So far as I can see, your netdevs will neither advertise LRO nor provide any
way to control it.  You need to implement ethtool get_flags/set_flags ops.
If you use the standard implementations then you can just test
priv->dev->features & NETIF_F_LRO here.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html