netdev - Re: [PATCH RFC 03/10] mlx4_en: net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <487CBBAF.9030704@mellanox.co.il>
Date:	Tue, 15 Jul 2008 18:01:03 +0300
From:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il,
	Roland Dreier <rdreier@...co.com>
Subject: Re: [PATCH RFC 03/10] mlx4_en: net_device implementation

Ben Hutchings wrote:
> 
> This is already under RTNL; why do you need your own semaphore?
> (And why are you using semaphores, not mutexes?)

We approach the device/port state from many functions, not all protected by the
RTNL lock.
You are right about the mutex, it needs to be changed.

Yevgeny
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html