netdev - Re: [PATCH RFC 01/10] mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada8ww3ez8y.fsf@cisco.com>
Date:	Tue, 15 Jul 2008 12:14:21 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il
Subject: Re: [PATCH RFC 01/10] mlx4_en: Include file

 > +struct mlx4_en_ctrl_seg {
 > +	__be32 op_own;
 > +#define MLX4_EN_BIT_DESC_OWN	0x80000000
 > +#define MLX4_EN_OPCODE_SEND	0xa
 > +#define MLX4_EN_OPCODE_LSO	0xe
 > +	__be32 size_vlan;
 > +#define MLX4_EN_BIT_INS_VLAN	0x4000
 > +	__be32 flags;
 > +#define MLX4_EN_BIT_NO_ICRC	0x2
 > +#define MLX4_EN_BIT_TX_COMP	0xc
 > +#define MLX4_EN_BIT_TX_IP_CS	0x10
 > +#define MLX4_EN_BIT_TX_TCP_CS	0x20
 > +	__be32 reserved;
 > +};
 > +#define CTRL_SIZE	sizeof(struct mlx4_en_ctrl_seg)
 > +
 > +struct mlx4_en_data_seg {
 > +	__be32 count;
 > +#define MLX4_EN_INLINE		0x80000000
 > +	__be32 mem_type;
 > +#define MLX4_EN_MEMTYPE_PAD	0x100
 > +	__be64 addr;
 > +};
 > +#define DS_SIZE		sizeof(struct mlx4_en_data_seg)
 > +
 > +struct mlx4_en_lso_seg {
 > +	__be16 mss;
 > +	__be16 header_size;
 > +#define LSO_PREFIX_SIZE		4
 > +	u8 header_data[0]; /* copy of L2/IP/TCP headers */
 > +#define MLX4_EN_MAX_LSO_HEADER	(MAX_DESC_SIZE - CTRL_SIZE - DS_SIZE)
 > +};

I think it would be better to reuse the mlx4_wqe_ctrl_seg,
mlx4_wqe_data_seg and mlx4_wqe_lso_seg already defined in
<linux/mlx4/qp.h>.  That was the whole point in putting those structures
in a common location.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html