netdev - Re: [PATCH RFC 02/10] mlx4_en: Device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adawsjndkc0.fsf@cisco.com>
Date:	Tue, 15 Jul 2008 12:21:51 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	Liran Liss <liranl@...lanox.co.il>, tziporet@...lanox.co.il
Subject: Re: [PATCH RFC 02/10] mlx4_en: Device initialization

 > +	/* Create a netdev for each port */
 > +	mlx4_foreach_port(i, mdev->ports_map) {
 > +		mlx4_info(mdev, "Activating port:%d\n", i);
 > +		if (mlx4_en_init_netdev(mdev, i, &mdev->profile.prof[i])) {
 > +			mdev->pndev[i] = NULL;
 > +			goto err_free_netdev;
 > +		}
 > +	}
 > +	return mdev;
 > +
 > +
 > +err_free_netdev:
 > +	for (i = 0; i < dev->caps.num_ports; i++) {
 > +		if (mdev->pndev[i])
 > +			mlx4_en_destroy_netdev(mdev->pndev[i]);
 > +	}

There's a strange asymmetry between the mlx4_foreach_port() loop and the
for () loop here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html