netdev - Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487D2CD6.2070303@garzik.org>
Date:	Tue, 15 Jul 2008 19:03:50 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dave Jones <davej@...hat.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

Dave Jones wrote:
> On Tue, Jul 15, 2008 at 06:18:30PM -0400, Jeff Garzik wrote:
> 
>  > * [extra project] would be highly useful for MMIO to fall back to PIO, 
>  > and vice versa, should any resource be unavailable.  Sometimes, mainly 
>  > with MMIO and broken/weird BIOSen, only the PIO PCI BARs will be filled 
>  > in with useful info.
> 
> Hmm, this bit might actually be fairly trivial on top of my other patch..
> 
> 
> --- linux-2.6.26.noarch/drivers/net/8139too.c~	2008-07-15 18:49:02.000000000 -0400
> +++ linux-2.6.26.noarch/drivers/net/8139too.c	2008-07-15 18:53:07.000000000 -0400
> @@ -784,6 +784,7 @@ static int __devinit rtl8139_init_board 
>  	DPRINTK("PIO region size == 0x%02X\n", pio_len);
>  	DPRINTK("MMIO region size == 0x%02lX\n", mmio_len);
>  
> +retry:
>  	if (use_io) {
>  		/* make sure PCI base addr 0 is PIO */
>  		if (!(pio_flags & IORESOURCE_IO)) {
> @@ -832,9 +833,10 @@ static int __devinit rtl8139_init_board 
>  		/* ioremap MMIO region */
>  		ioaddr = pci_iomap(pdev, 1, 0);
>  		if (ioaddr == NULL) {
> -			dev_err(&pdev->dev, "cannot remap MMIO, aborting\n");
> -			rc = -EIO;
> -			goto err_out;
> +			dev_err(&pdev->dev, "cannot remap MMIO, trying PIO\n");
> +			pci_release_regions(pdev);
> +			use_ui = 1;
> +			goto retry;

use_ui?  Are you sure this is not not an X.org patch?  :)

Yes, seems like that would do the trick quite nicely...

If you would be kind enough to post this as a separate patch from your 
use_io patch (since IMO its a separate logical change), that would be 
helpful.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html