netdev - Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2008 19:14:57 -0400
From:	Dave Jones <davej@...hat.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] 8139too: Make PIO/MMIO a modparam

On Tue, Jul 15, 2008 at 06:55:42PM -0400, Jeff Garzik wrote:

 > >  > * [optional] would prefer CONFIG_8139TOO_PIO be handled at compile time, 
 > >  > by changing the initialized value
 > > 
 > > This bit should be taken care of in rtl8139_init_module() at the bottom..
 > > 
 > > +       /* enable PIO instead of MMIO, if CONFIG_8139TOO_PIO is selected */
 > > +#ifdef CONFIG_8139TOO_PIO
 > > +       use_io = 1;
 > > +#endif
 > 
 > Right, I was saying I prefer simply to set the initialized value 
 > appropriately, and avoid the extra code dollup during module load.

Oh, you mean something like..

static int use_io = CONFIG_8139TOO_PIO;

?

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html