netdev - Re: [PATCH 1/13]: netdev: Allocate multiple queues for TX.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080715.024519.95002238.davem@davemloft.net>
Date:	Tue, 15 Jul 2008 02:45:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/13]: netdev: Allocate multiple queues for TX.

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 11 Jul 2008 23:19:39 +0200

> On i386 for example, sizeof(struct netdev_queue) = 0x2c
> 
> Shouldnt we make sure each queue sits on its own cache line on CONFIG_SMP ?

Yes.

> Also, dev->_tx and dev->num_tx_queues might share a cache line with
> dev->rx_queue, was it intended ?

Nope.

I've added the ____cacheline_aligned_in_smp annotations to my
tree, thanks!

@@ -463,7 +463,7 @@ struct netdev_queue {
 	struct Qdisc		*qdisc_sleeping;
 	struct list_head	qdisc_list;
 	struct netdev_queue	*next_sched;
-};
+} ____cacheline_aligned_in_smp;
 ...
@@ -641,7 +641,9 @@ struct net_device
 	unsigned char		broadcast[MAX_ADDR_LEN];	/* hw bcast add	*/
 
 	struct netdev_queue	rx_queue;
-	struct netdev_queue	tx_queue ____cacheline_aligned_in_smp;
+
+	struct netdev_queue	*_tx ____cacheline_aligned_in_smp;
+	unsigned int		num_tx_queues;
 	unsigned long		tx_queue_len;	/* Max frames per queue allowed */
 ...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html