netdev - Re: IPV4: Enable IP_ID sequencing for all traffic (inquiring minds want to know why its set to zero)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080716.140100.20638484.davem@davemloft.net>
Date:	Wed, 16 Jul 2008 14:01:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rick.jones2@...com
Cc:	cl@...ux-foundation.org, dlstevens@...ibm.com,
	netdev@...r.kernel.org, netdev-owner@...r.kernel.org
Subject: Re: IPV4: Enable IP_ID sequencing for all traffic (inquiring minds
 want to know why its set to zero)

From: Rick Jones <rick.jones2@...com>
Date: Wed, 16 Jul 2008 13:39:37 -0700

> I have vague recollections of wanting to avoid (then) locks on the 
> increment in the non-fragmented paths, assertions that covering cases 
> like intermediate devices ignoring DF and fragmenting anyway didn't 
> warrant concern etc.

Partially, yes.

If you look, we do increment the ID for TCP connections which will
be setting IP_DF, but we allocate such IDs in a socket-local manner
which keeps these allocations from depleating the real ID cache
for that destination.

This is legal because when IP_DF is set, the IDs serve no purpose.

We had to do this because TCP header compression, used by SLIP et
al., depends upon the ID value incrementing.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html