netdev - Re: [PATCH 05/10] r6040: call napi_disable when puting down the interface and set lp->dev accordingly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080716210138.GB27394@electric-eye.fr.zoreil.com>
Date:	Wed, 16 Jul 2008 23:01:38 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	netdev@...r.kernel.org, jeff@...zik.org
Subject: Re: [PATCH 05/10] r6040: call napi_disable when puting down the
	interface and set lp->dev accordingly.

Florian Fainelli <florian.fainelli@...ecomint.eu> :
> We did not call napi_disabled when putting down the interface
> which should be done. Finally initialize lp->dev when everything
> is set.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...ecomint.eu>
> ---
> diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
> index 4f2ebb2..5eb057d 100644
> --- a/drivers/net/r6040.c
> +++ b/drivers/net/r6040.c
[...]
> @@ -1080,8 +1081,6 @@ static int __devinit r6040_init_one(struct pci_dev *pdev,
>  	}
>  	SET_NETDEV_DEV(dev, &pdev->dev);
>  	lp = netdev_priv(dev);
> -	lp->pdev = pdev;
> -	lp->dev = dev;
>  
>  	if (pci_request_regions(pdev, DRV_NAME)) {
>  		printk(KERN_ERR DRV_NAME ": Failed to request PCI regions\n");

Can you fix the error paths of r6040_init_one as well ?

They badly leak.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html