netdev - Re: [PATCH 0/2]: VLAN filtering fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390807161403g6db1247due0a209a088846a89@mail.gmail.com>
Date:	Wed, 16 Jul 2008 14:03:33 -0700
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>,
	"Linux Netdev List" <netdev@...r.kernel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: Re: [PATCH 0/2]: VLAN filtering fixes

On Wed, Jul 16, 2008 at 2:43 AM, Patrick McHardy <kaber@...sh.net> wrote:
> These two patches contain the last bits of my VLAN + tcpdump fixes.
> Currently some (all?) drivers have inconsistent behaviour wrt. VLAN
> filtering and promiscous mode:
>
> They start with disabled VLAN filtering, meaning all VLAN packets
> are received on packet sockets. When adding the first VLAN, VLAN
> filtering is enabled and only packets for locally configured VLANs
> are received, even in promiscous mode. In most cases VLAN filtering
> is disabled again when removing the last VLAN, igxbe keeps it enabled
> permanently however.
>
> These patches change the Intel drivers to always enable VLAN filtering
> while not in promiscous mode since there is little point in receiving
> VLAN packets while nothing is interested in them, but disable filtering
> while in promiscous mode so all VLANs are visible to packet sockets.
>
> There are four more drivers that support VLAN filtering that I didn't
> adapt to this behaviour since I'm not sure about what exactly they
> currently do. All four of tehuti, starfire, ehea and via-velocity
> have a flag for the hardware to enable promiscous mode, its unknown
> to me whether this also automatically disables VLAN filtering.
> Any information on this someone might have is appreciated.
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>


-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html