netdev - Re: [PATCH] e1000: resolve tx multiqueue bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390807181704u4e969d2bpb39683b7160b4939@mail.gmail.com>
Date:	Fri, 18 Jul 2008 17:04:42 -0700
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>,
	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] e1000: resolve tx multiqueue bug

On Fri, Jul 18, 2008 at 10:05 AM, Ben Hutchings
<bhutchings@...arflare.com> wrote:
> With the recent changes to tx mutiqueue, e1000 was not calling
> netif_start_queue() before calling netif_wake_queue().
> This causes an oops during loading of the driver.
>
> (Based on commit d55b53fff0c2ddb639dca04c3f5a0854f292d982.)
>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index f8df8bd..cf12b05 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -1472,6 +1472,8 @@ e1000_open(struct net_device *netdev)
>
>        e1000_irq_enable(adapter);
>
> +       netif_start_queue(netdev);
> +
>        /* fire a link status change interrupt to start the watchdog */
>        E1000_WRITE_REG(&adapter->hw, ICS, E1000_ICS_LSC);
>
> --

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html