netdev - Re: [PATCH] e1000: resolve tx multiqueue bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080718.175132.57732510.davem@davemloft.net>
Date:	Fri, 18 Jul 2008 17:51:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	bhutchings@...arflare.com, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e1000: resolve tx multiqueue bug

From: "Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
Date: Fri, 18 Jul 2008 17:04:42 -0700

> On Fri, Jul 18, 2008 at 10:05 AM, Ben Hutchings
> <bhutchings@...arflare.com> wrote:
> > With the recent changes to tx mutiqueue, e1000 was not calling
> > netif_start_queue() before calling netif_wake_queue().
> > This causes an oops during loading of the driver.
> >
> > (Based on commit d55b53fff0c2ddb639dca04c3f5a0854f292d982.)
...
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks everyone.

Jeff, really, I think those wake/stop queue calls in the PHY link
state watching code of all of these drivers should just flat out
be removed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html