netdev - Re: netif_schedule and mpc5200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080722.163626.109432106.davem@davemloft.net>
Date:	Tue, 22 Jul 2008 16:36:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jonsmirl@...il.com
Cc:	Linuxppc-dev@...abs.org, netdev@...r.kernel.org, davem@...hat.com
Subject: Re: netif_schedule and mpc5200_fec

From: "Jon Smirl" <jonsmirl@...il.com>
Date: Tue, 22 Jul 2008 19:33:13 -0400

> On 7/22/08, David Miller <davem@...emloft.net> wrote:
> > From: "Jon Smirl" <jonsmirl@...il.com>
> >
> > Date: Tue, 22 Jul 2008 18:54:18 -0400
> >
> >
> >  > On 7/22/08, David Miller <davem@...emloft.net> wrote:
> >  > > From: "Jon Smirl" <jonsmirl@...il.com>
> >  > >  Date: Tue, 22 Jul 2008 17:03:32 -0400
> >  > >
> >  > >
> >  > > > On 7/22/08, Jon Smirl <jonsmirl@...il.com> wrote:
> >  > >  > > I just updated to linus/master and mpc5200_fec won't boot.
> >  > >  >
> >  > >  > It does boot, but this badness looks like it is coming from this
> >  > >  > patch. I don't know enough about networking to debug it.
> >  > >
> >  > >
> >  > > I just applied the following patch from Anton Vorontsov which
> >  > >  will fix this.
> >  >
> >  > I applied this piece and still have the same error.
> >
> >
> > There are no calls to functions in mpc52xx_fec_adjust_link that
> >  can lead to __netif_schedule() any more.
> >
> >  Therefore I can't see how your backtrace is even possible.
> >
> >  Please double check that you've really applied the patch
> >  and that mpc52xx_fec_adjust_link lacks any calls to
> >  netif_*_queue() and *netif_schedule().
> 
> You're right. That patch fixes it. Another thing I brought down made
> my image file not get generated and I was using an old image.

Thanks for confirming this Jon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html