netdev - Re: Fix typo in meth driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48866FBC.1030008@garzik.org>
Date:	Tue, 22 Jul 2008 19:39:40 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Christoph Lameter <cl@...ux-foundation.org>
CC:	Kay Sievers <kay.sievers@...y.org>, netdev@...r.kernel.org
Subject: Re: Fix typo in meth driver

Christoph Lameter wrote:
> An | in an if statement to check a bit? I think this needs to be a &.
> As a result of this typo meth will always operate in promiscuous mode.
> 
> Signed-off-by: Christoph Lameter <cl@...ux-foundation.org>
> 
> Index: linux-2.6/drivers/net/meth.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/meth.c	2008-07-11 16:05:00.000000000 -0500
> +++ linux-2.6/drivers/net/meth.c	2008-07-11 16:05:02.000000000 -0500
> @@ -287,7 +287,7 @@
>  
>  	/* Initial mode: 10 | Half-duplex | Accept normal packets */
>  	priv->mac_ctrl = METH_ACCEPT_MCAST | METH_DEFAULT_IPG;
> -	if (dev->flags | IFF_PROMISC)
> +	if (dev->flags & IFF_PROMISC)
>  		priv->mac_ctrl |= METH_PROMISC;
>  	mace->eth.mac_ctrl = priv->mac_ctrl;
>  

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html