netdev - Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080726.003617.265743493.davem@davemloft.net>
Date:	Sat, 26 Jul 2008 00:36:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	vladislav.yasevich@...com, netdev@...r.kernel.org
Subject: Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not)
 redundant?

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sat, 26 Jul 2008 08:03:08 +0100

> If `goto out' is replaced with `goto out_err' in icmp_unreach(),
> it may be worth considering the analogous case in icmpv6_notify():
> 
> 	/* Checkin header including 8 bytes of inner protocol header. */
>         if (!pskb_may_pull(skb, inner_offset+8))
>                 return;
> 
> and the `discard_it' jump label in icmpv6_rcv().

What if the lower protocol doesn't have a header that it
at least 8 bytes? :-)

I think that's yet another reason why the check and counter bump were
originally down in the per-protocol hander.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html