netdev - Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080726081007.GA7299@gerrit.erg.abdn.ac.uk>
Date:	Sat, 26 Jul 2008 09:10:07 +0100
From:	Gerrit Renker <gerrit@....abdn.ac.uk>
To:	David Miller <davem@...emloft.net>
Cc:	vladislav.yasevich@...com, netdev@...r.kernel.org
Subject: Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not)
	redundant?

| What if the lower protocol doesn't have a header that it
| at least 8 bytes? :-)
| 
| I think that's yet another reason why the check and counter bump were
| originally down in the per-protocol hander.
| 
The only reason I can think of is RFC 1122, 3.2.2:
 "Every ICMP error message includes the Internet header and at
  least the first 8 data octets of the datagram that triggered
  the error; more than 8 octets MAY be sent [...]"

But for ICMPv6 the requirement is less strict (RFC 4443, 2.4):
 "Every ICMPv6 error message (type < 128) MUST include as much of
  the IPv6 offending (invoking) packet (the packet that caused the
  error) as possible without making the error message packet exceed
  the minimum IPv6 MTU [IPv6]."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html