netdev - Re: baycom_ser_fdx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080728103242.GN3820@mea-ext.zmailer.org>
Date:	Mon, 28 Jul 2008 13:32:42 +0300
From:	Matti Aarnio <matti.aarnio@...iler.org>
To:	Peter Mallett <zl2bau@...t.co.nz>
Cc:	Pidoux <f6bvp@...e.fr>, David Robb <ender@...adise.gen.nz>,
	linux-hams@...r.kernel.org, David Miller <davem@...emloft.net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: baycom_ser_fdx - fixed under 2.6

On Mon, Jul 28, 2008 at 03:44:22PM +1200, Peter Mallett wrote:
> Pidoux wrote:
>> Hi,
....
>> 73 de Bernard, f6bvp
>>
>> --- a/drivers/net/hamradio/hdlcdrv.c    2008-07-22 10:40:20.000000000 +0200
>> +++ b/drivers/net/hamradio/hdlcdrv.c    2008-07-22 10:42:13.000000000 +0200
>> @@ -88,6 +88,7 @@
>>  static inline void append_crc_ccitt(unsigned char *buffer, int len)
>>  {
>>       unsigned int crc = crc_ccitt(0xffff, buffer, len) ^ 0xffff;
>> +    buffer += len;
>>      *buffer++ = crc;
>>      *buffer++ = crc >> 8;
>>  }
....
> Hi,
>
>    The Baycom MoDem problem is one I have battled for quite a while here.
>
> How do I apply this patch to my Ubuntu 2.6.20-17-generic kernel.
>
> I have the linux-source-2.6.20-2.6.20 source so which file do I apply  
> the patch too ?

Officially:

  patch -p1 < patch.text

Easier for you:

 - pick editor that you know how to use (nano, vi, emacs, joe, jove...)
 - edit file  drivers/net/hamradio/hdlcdrv.c
   - locate function  append_crc_ccitt
   - add missing line

> Then I need to recompile it ?

Yes.

Better would be to rebuild your kernel runtime in distribution specific
way -- which I do not know for Ubuntu.


> Would this bug also affect the SCC Baycom card ?

No.  It does HDLC framing in hardware.

> Regards ..... Peter

73 de Matti, OH2MQK
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html