netdev - Re: [PATCH] smc91c92_cs: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080728082814.GA4708@isilmar.linta.de>
Date:	Mon, 28 Jul 2008 10:28:14 +0200
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, dahinds@...rs.sourceforge.net,
	becker@...ld.com, x-csrdh@....edu.au, erik@...edu,
	Jeff Garzik <jeff@...zik.org>, netdev <netdev@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] smc91c92_cs: use request_firmware

Hi,

On Sun, Jul 27, 2008 at 08:22:21PM +0530, Jaswinder Singh wrote:
> +static int osi_load_firmware(struct pcmcia_device *link)
> +{
> +	struct platform_device *pdev;
> +	const struct firmware *fw;
> +	const char fw_name[] = "ositech/Xilinx7OD.bin"; 
> +	int i, err;
> + 
> +	pdev = platform_device_register_simple("ositech", 0, NULL, 0);

Why do we need a platform_device here? Can't we just use the pcmcia device
(so &link->dev) here?

Thanks,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html