netdev - Re: using software TSO on non-TSO capable netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080731105522.GB7601@gondor.apana.org.au>
Date:	Thu, 31 Jul 2008 18:55:22 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	akarkare@...vell.com, nico@....org
Subject: Re: using software TSO on non-TSO capable netdevices

On Thu, Jul 31, 2008 at 11:45:36AM +0200, Lennert Buytenhek wrote:
>
> From: Lennert Buytenhek <buytenh@...tstofly.org>
> Subject: [NET] use software GSO for SG+CSUM capable netdevices
> 
> If a netdevice does not support hardware GSO, allowing the stack to
> use GSO anyway and then splitting the GSO skb into MSS-sized pieces
> as it is handed to the netdevice for transmitting is likely still
> a win at least as far as CPU usage is concerned, since it reduces
> the number of trips through the output path.
> 
> This patch enables the use of GSO on any netdevice that supports SG
> and hardware checksumming.  If a GSO skb is then sent to a netdevice
> that supports SG and checksumming but does not support hardware GSO,
> net/core/dev.c:dev_hard_start_xmit() will take care of doing the
> necessary GSO segmentation in software.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> 
> Index: linux-2.6.27-rc1/include/net/sock.h
> ===================================================================
> --- linux-2.6.27-rc1.orig/include/net/sock.h
> +++ linux-2.6.27-rc1/include/net/sock.h
> @@ -1085,7 +1085,12 @@ extern struct dst_entry *sk_dst_check(st
>  
>  static inline int sk_can_gso(const struct sock *sk)
>  {
> -	return net_gso_ok(sk->sk_route_caps, sk->sk_gso_type);
> +	int caps = sk->sk_route_caps;
> +	int type = sk->sk_gso_type;
> +
> +	return (caps & NETIF_F_SG) &&
> +		 ((type == SKB_GSO_TCPV4 && (caps & NETIF_F_V4_CSUM)) ||
> +		  (type == SKB_GSO_TCPV6 && (caps & NETIF_F_V6_CSUM)));

I think you've lost the hardware UFO support.

In any case, this is really the wrong place to do this as the
user will no longer be able to disable it.

Please do it in the netdev registration function instead.  The code
should enable NETIF_F_GSO if NETIF_F_SG is on.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html