netdev - [PATCH] net: Add missing extra2 parameter for ip_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0808032214130.29048@titan.stealer.net>
Date:	Sun, 3 Aug 2008 22:18:59 +0200 (CEST)
From:	Sven Wegener <sven.wegener@...aler.net>
To:	"David S. Miller" <davem@...emloft.net>
cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
	"Denis V. Lunev" <den@...nvz.org>
Subject: [PATCH] net: Add missing extra2 parameter for ip_default_ttl
 sysctl

Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of
the ip_default_ttl ctl_table, but it is never set to a meaningful value. When
e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in
rt_cache_invalidate(). Set extra2 to init_net, to avoid that.

Reported-by: Marcin Slusarz <marcin.slusarz@...il.com>
Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
Tested-by: Marcin Slusarz <marcin.slusarz@...il.com>
Acked-by: Denis V. Lunev <den@...nvz.org>
---
 net/ipv4/sysctl_net_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 770d827..e0689fd 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &ipv4_doint_and_flush,
 		.strategy	= &ipv4_doint_and_flush_strategy,
+		.extra2		= &init_net,
 	},
 	{
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html