netdev - Re: [PATCH] net: Add missing extra2 parameter for ip_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080803.140751.57839905.davem@davemloft.net>
Date:	Sun, 03 Aug 2008 14:07:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sven.wegener@...aler.net
Cc:	marcin.slusarz@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, den@...nvz.org
Subject: Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttl
 sysctl

From: Sven Wegener <sven.wegener@...aler.net>
Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST)

> Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 acceses the extra2 parameter of
> the ip_default_ttl ctl_table, but it is never set to a meaningful value. When
> e84f84f276473dcc673f360e8ff3203148bdf0e2 is applied, we'll oops in
> rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
> 
> Reported-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
> Tested-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Acked-by: Denis V. Lunev <den@...nvz.org>

Applied, thanks a lot.

Please provide commit header line text when referencing SHA IDs,
as the SHA IDs can change when patches are applied to different
trees.  Here is the actual changelog message I used so you can
see what I mean:

    net: Add missing extra2 parameter for ip_default_ttl sysctl
    
    Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace
    parameter to rt_cache_flush") acceses the extra2 parameter of the
    ip_default_ttl ctl_table, but it is never set to a meaningful
    value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place
    rt_genid into struct net") is applied, we'll oops in
    rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
    
    Reported-by: Marcin Slusarz <marcin.slusarz@...il.com>
    Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
    Tested-by: Marcin Slusarz <marcin.slusarz@...il.com>
    Acked-by: Denis V. Lunev <den@...nvz.org>
    Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html