netdev - Re: [PATCH 2/2] myri10ge: use ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489ED823.6000005@myri.com>
Date:	Sun, 10 Aug 2008 13:59:31 +0200
From:	Brice Goglin <brice@...i.com>
To:	Martin Michlmayr <tbm@...ius.com>
CC:	Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] myri10ge: use ioremap_wc

Martin Michlmayr wrote:
> * Brice Goglin <brice@...i.com> [2008-07-21 10:26]:
>   
>> Switch to ioremap_wc(). We keep the MTRR code since ioremap_wc()
>> will use UC_MINUS when falling back to uncachable, and thus let
>> the MTRR WC take precedence.
>>     
>
> This change leads to a compilation failure on (at least) arm:
>
>   CC [M]  drivers/net/myri10ge/myri10ge.o
> drivers/net/myri10ge/myri10ge.c: In function ‘myri10ge_probe’:
> drivers/net/myri10ge/myri10ge.c:3725: error: implicit declaration of function ‘ioremap_wc’
> drivers/net/myri10ge/myri10ge.c:3725: warning: assignment makes pointer from integer without a cast
> make[3]: *** [drivers/net/myri10ge/myri10ge.o] Error 1
>   


Isn't arm's asm/io.h supposed to get
#ifndef ARCH_HAS_IOREMAP_WC
#define ioremap_wc ioremap_nocache
#endif
from asm-generic/iomap.h since ARCH_HAS_IOREMAP_WC isn't defined on arm ?

Brice

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html