netdev - Re: [PATCH 2/2] myri10ge: use ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080810123844.GG2486@deprecation.cyrius.com>
Date:	Sun, 10 Aug 2008 15:38:44 +0300
From:	Martin Michlmayr <tbm@...ius.com>
To:	Brice Goglin <brice@...i.com>
Cc:	Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org,
	Russell King - ARM Linux <linux@....linux.org.uk>
Subject: Re: [PATCH 2/2] myri10ge: use ioremap_wc

* Brice Goglin <brice@...i.com> [2008-08-10 13:59]:
> > This change leads to a compilation failure on (at least) arm:
> >
> >   CC [M]  drivers/net/myri10ge/myri10ge.o
> > drivers/net/myri10ge/myri10ge.c: In function ‘myri10ge_probe’:
> > drivers/net/myri10ge/myri10ge.c:3725: error: implicit declaration of function ‘ioremap_wc’
> > drivers/net/myri10ge/myri10ge.c:3725: warning: assignment makes pointer from integer without a cast
> > make[3]: *** [drivers/net/myri10ge/myri10ge.o] Error 1
> 
> Isn't arm's asm/io.h supposed to get
> #ifndef ARCH_HAS_IOREMAP_WC
> #define ioremap_wc ioremap_nocache
> #endif
> from asm-generic/iomap.h since ARCH_HAS_IOREMAP_WC isn't defined on arm ?

arch/arm/include/asm/io.h doesn't include asm-generic/iomap.h.  When I
add this includes, myri10ge compiles.

Russell, any comments on the change below?

diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index 94a95d7..eb71224 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -26,6 +26,7 @@
 #include <linux/types.h>
 #include <asm/byteorder.h>
 #include <asm/memory.h>
+#include <asm-generic/iomap.h>
 
 /*
  * ISA I/O bus memory addresses are 1:1 with the physical address.

-- 
Martin Michlmayr
http://www.cyrius.com/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html