netdev - Re: drivers/net/ipg.h: remove duplicated #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080810155434.GA31528@electric-eye.fr.zoreil.com>
Date:	Sun, 10 Aug 2008 17:54:34 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Huang Weiyi <weiyi.huang@...il.com>
Cc:	jgarzik@...ox.com, jgarzik@...hat.com, netdev@...r.kernel.org
Subject: Re: drivers/net/ipg.h: remove duplicated #include

Huang Weiyi <weiyi.huang@...il.com> :
> Removed duplicated include <linux/version.h>
> in drivers/net/ipg.h
> 
> Signed-off-by: Huang Weiyi <weiyi.huang@...il.com>

Acked-off-by: Francois Romieu <romieu@...zoreil.com>

The driver does not use LINUX_VERSION_CODE nor KERNEL_VERSION.
I would not mind a patch to remove completely the said #include.

It could make some sense for the files below too:

drivers/net/acenic.c
drivers/net/bnx2x_link.c
drivers/net/bnx2x_main.c
drivers/net/cpmac.c
drivers/net/gianfar_sysfs.c
drivers/net/ppp_mppe.c
drivers/net/pppol2tp.c
drivers/net/r6040.c
drivers/net/sh_eth.c
drivers/net/sky2.c
drivers/net/tehuti.h
drivers/net/typhoon.c

Can you take care of those ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html