netdev - Re: csum offload and af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080812005839.GC18547@gondor.apana.org.au>
Date:	Tue, 12 Aug 2008 08:58:39 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	rusty@...tcorp.com.au, anthony@...emonkey.ws,
	netdev@...r.kernel.org
Subject: Re: csum offload and af_packet

On Mon, Aug 11, 2008 at 05:51:54PM -0700, David Miller wrote:
>
> Unfortunately the censored version doesn't allow you to get at the
> link level headers, which is what at least some of these applications
> want.

Yes that is certainly true for the DHCP server, but Rusty was
complaining about the DHCP client which certainly does not need
the LL headers on reception (although using it is definitely more
convenient since you need it on transmit anyway).

I agree that handling this in AF_PACKET is certainly possible,
and for that matter not extremely difficult.  However, my point is
that doing this for the purposes of virtualisation is completely
pointless.

The only time you need this is when you have an old guest that
you cannot modify.  If you could modify it you can always give it
a patched DHCP client (I've alread patched dhcp-client for Xen
so that should work properly for KVM/lguest if you're using the
latest version).

And if you can't modify it then patching AF_PACKET is completely
pointless since we need to do this in the guest kernel and not the
host kernel.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html