netdev - Re: OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output, rt6_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48A0DC32.9030309@hp.com>
Date:	Mon, 11 Aug 2008 20:41:22 -0400
From:	Brian Haley <brian.haley@...com>
To:	Eugene Teo <eugeneteo@...nel.sg>
CC:	Alexey Dobriyan <adobriyan@...il.com>,
	John Gumb <john.gumb@...dberg.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: OOPS, ip -f inet6 route get fec0::1, linux-2.6.26,	ip6_route_output,
 rt6_fill_node+0x175

Eugene Teo wrote:
> I think it's better to use a helper routine like ipv6_get_saddr to make
> sure that both dst and rt6i_idev arguments are checked for NULL.
> 
> I have compiled, and tested the patch.
> 
> Thanks,
> Eugene
> 
> ---
> Fix NULL pointer dereference in rt6_fill_node().
> 
> # ip -f inet6 route get fec0::1
> 
> BUG: unable to handle kernel NULL pointer dereference at 00000000
> IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0
> EIP is at rt6_fill_node+0x175/0x3b0
> 
> Cc: Stable <stable@...nel.org>
> Signed-off-by: Eugene Teo <eugeneteo@...nel.sg>

Acked-by: Brian Haley <brian.haley@...com>

But Yoshfuji might have another opinion since he did the work to remove 
ipv6_get_saddr() in the first place.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html