[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48A492B8.8010109@hp.com>
Date: Thu, 14 Aug 2008 16:16:56 -0400
From: Brian Haley <brian.haley@...com>
To: Vlad Yasevich <vladislav.yasevich@...com>
CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
containers <containers@...ts.osdl.org>,
linux-sctp@...r.kernel.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node()
and ipv6_dev_get_saddr()
Hi Vlad,
Vlad Yasevich wrote:
> Hi Brian
>
> Brian Haley wrote:
>> ---
>>
>> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
>> index 483a01d..e0945d4 100644
>> --- a/net/sctp/ipv6.c
>> +++ b/net/sctp/ipv6.c
>> @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
>> __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
>>
>> if (!asoc) {
>> - ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
>> + ipv6_dev_get_saddr(NULL,
>> + dst ? ip6_dst_idev(dst)->dev : NULL,
>> &daddr->v6.sin6_addr,
>> inet6_sk(&sk->inet.sk)->srcprefs,
>> &saddr->v6.sin6_addr);
>
>
> I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.
Thanks Vlad, I didn't see that. I noticed the xfrm code could pass
non-NULL has well, I'll respin.
-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists