netdev - Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218745124.16589.73.camel@iris.sw.ru>
Date:	Fri, 15 Aug 2008 00:18:44 +0400
From:	"Denis V. Lunev" <den@...allels.com>
To:	Vlad Yasevich <vladislav.yasevich@...com>
Cc:	Brian Haley <brian.haley@...com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	containers <containers@...ts.osdl.org>,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in
	rt6_fill_node() and ipv6_dev_get_saddr()

On Thu, 2008-08-14 at 16:04 -0400, Vlad Yasevich wrote:
> Hi Brian
> 
> Brian Haley wrote:
> > ---
> > 
> > diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> > index 483a01d..e0945d4 100644
> > --- a/net/sctp/ipv6.c
> > +++ b/net/sctp/ipv6.c
> > @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
> >  			  __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
> >  
> >  	if (!asoc) {
> > -		ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
> > +		ipv6_dev_get_saddr(NULL,
> > +				   dst ? ip6_dst_idev(dst)->dev : NULL,
> >  				   &daddr->v6.sin6_addr,
> >  				   inet6_sk(&sk->inet.sk)->srcprefs,
> >  				   &saddr->v6.sin6_addr);
> 
> 
> I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.

this looks safe to me

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html