netdev - e1000e: Silly repetition of PCI name in log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808181219.39921.elendil@planet.nl>
Date:	Mon, 18 Aug 2008 12:19:39 +0200
From:	Frans Pop <elendil@...net.nl>
To:	netdev@...r.kernel.org
Subject: e1000e: Silly repetition of PCI name in log message

With 2.6.27-rc3 I noticed the following messages in my boot log:
0000:01:00.0: 0000:01:00.0: Warning: detected DSPD enabled in EEPROM
0000:01:00.0: eth0: (PCI Express:2.5GB/s:Width x1) 00:16:76:04:ff:09

The second seems correct, but the first has a silly repetition of the PCI 
device before the actual message. The message originates from 
e1000_eeprom_checks in e1000e/netdev.c.
Is this because e_warn in (which calls e_printk from e1000e/e1000.h) is 
used before adapter->netdev->name has been properly set? Looks likely as 
the eeprom checks are done some time before the device is registered.

Other question is why this is a "Warning"? Isn't "Deep Smart Power Down" a 
desirable feature to have?

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html