lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Aug 2008 20:02:46 +0200 From: Frans Pop <elendil@...net.nl> To: netdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org Subject: [PATCH] e1000e: Avoid duplicated output of device name in kernel warning On Monday 18 August 2008, Frans Pop wrote: > With 2.6.27-rc3 I noticed the following messages in my boot log: > 0000:01:00.0: 0000:01:00.0: Warning: detected DSPD enabled in EEPROM > 0000:01:00.0: eth0: (PCI Express:2.5GB/s:Width x1) 00:16:76:04:ff:09 > > The second seems correct, but the first has a silly repetition of the > PCI device before the actual message. The message originates from > e1000_eeprom_checks in e1000e/netdev.c. With the patch below the first message becomes e1000e 0000:01:00.0: Warning: detected DSPD enabled in EEPROM which makes it similar to directly preceding messages. > Other question is why this is a "Warning"? Isn't "Deep Smart Power > Down" a desirable feature to have? I'm still wondering about this... Same goes for the "warning" about ASPM. --- From: Frans Pop <elendil@...net.nl> Use dev_warn instead of e_warn in e1000_eeprom_checks() as the interface name has not yet been assigned at that point. Signed-off-by: Frans Pop <elendil@...net.nl> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index d266510..d02a659 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -4335,13 +4335,15 @@ static void e1000_eeprom_checks(struct e1000_adapter *adapter) ret_val = e1000_read_nvm(hw, NVM_INIT_CONTROL2_REG, 1, &buf); if (!(le16_to_cpu(buf) & (1 << 0))) { /* Deep Smart Power Down (DSPD) */ - e_warn("Warning: detected DSPD enabled in EEPROM\n"); + dev_warn(&adapter->pdev->dev, + "Warning: detected DSPD enabled in EEPROM\n"); } ret_val = e1000_read_nvm(hw, NVM_INIT_3GIO_3, 1, &buf); if (le16_to_cpu(buf) & (3 << 2)) { /* ASPM enable */ - e_warn("Warning: detected ASPM enabled in EEPROM\n"); + dev_warn(&adapter->pdev->dev, + "Warning: detected ASPM enabled in EEPROM\n"); } } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists