netdev - Re: [PATCH] forcedeth: fix checksum flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080818145442.659ab3a3.akpm@linux-foundation.org>
Date:	Mon, 18 Aug 2008 14:54:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ayaz Abdulla <aabdulla@...dia.com>
Cc:	jgarzik@...ox.com, manfred@...orfullife.com, netdev@...r.kernel.org
Subject: Re: [PATCH] forcedeth: fix checksum flag

On Thu, 14 Aug 2008 18:49:09 -0400
Ayaz Abdulla <aabdulla@...dia.com> wrote:

> This patch fixes the checksum feature advertised in device flags. The 
> hardware support TCP/UDP over IPv4 and TCP/UDP over IPv6 (without IPv6 
> extension headers). However, the kernel feature flags do not distinguish 
>   IPv6 with/without extension headers.
> 
> Therefore, the driver needs to use NETIF_F_IP_CSUM instead of 
> NETIF_F_HW_CSUM since the latter includes all IPv6 packets.
> 
> A future patch can created to check for extension headers and perform 
> software checksum calculation.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> 
> 
> [patch-forcedeth-ipv4csum  text/plain (780B)]
> --- old/drivers/net/forcedeth.c	2008-08-14 18:37:11.000000000 -0400
> +++ new/drivers/net/forcedeth.c	2008-08-14 18:37:05.000000000 -0400
> @@ -5522,7 +5522,7 @@
>  	if (id->driver_data & DEV_HAS_CHECKSUM) {
>  		np->rx_csum = 1;
>  		np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
> -		dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;
> +		dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
>  		dev->features |= NETIF_F_TSO;
>  	}
>  
> @@ -5835,7 +5835,7 @@
>  
>  	dev_printk(KERN_INFO, &pci_dev->dev, "%s%s%s%s%s%s%s%s%s%sdesc-v%u\n",
>  		   dev->features & NETIF_F_HIGHDMA ? "highdma " : "",
> -		   dev->features & (NETIF_F_HW_CSUM | NETIF_F_SG) ?
> +		   dev->features & (NETIF_F_IP_CSUM | NETIF_F_SG) ?
>  		   	"csum " : "",
>  		   dev->features & (NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_TX) ?
>  		   	"vlan " : "",
> 

Is this fix needed in 2.6.25.x and 2.6.26.x?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html