netdev - Re: [PATCH] forcedeth: fix checksum flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1KVQnK-0001Re-00@gondolin.me.apana.org.au>
Date:	Tue, 19 Aug 2008 22:58:42 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	akpm@...ux-foundation.org (Andrew Morton)
Cc:	aabdulla@...dia.com, jgarzik@...ox.com, manfred@...orfullife.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] forcedeth: fix checksum flag

Andrew Morton <akpm@...ux-foundation.org> wrote:
>
>> --- old/drivers/net/forcedeth.c       2008-08-14 18:37:11.000000000 -0400
>> +++ new/drivers/net/forcedeth.c       2008-08-14 18:37:05.000000000 -0400
>> @@ -5522,7 +5522,7 @@
>>       if (id->driver_data & DEV_HAS_CHECKSUM) {
>>               np->rx_csum = 1;
>>               np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
>> -             dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;
>> +             dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
>>               dev->features |= NETIF_F_TSO;
>>       }
>>  
>> @@ -5835,7 +5835,7 @@
>>  
>>       dev_printk(KERN_INFO, &pci_dev->dev, "%s%s%s%s%s%s%s%s%s%sdesc-v%u\n",
>>                  dev->features & NETIF_F_HIGHDMA ? "highdma " : "",
>> -                dev->features & (NETIF_F_HW_CSUM | NETIF_F_SG) ?
>> +                dev->features & (NETIF_F_IP_CSUM | NETIF_F_SG) ?
>>                       "csum " : "",
>>                  dev->features & (NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_TX) ?
>>                       "vlan " : "",
> 
> Is this fix needed in 2.6.25.x and 2.6.26.x?

Yep it's needed for all kernels.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html