netdev - Re: [PATCH] Remove duplicated unlikely() in IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1219125321.18027.9.camel@sauron>
Date:	Tue, 19 Aug 2008 08:55:20 +0300
From:	Artem Bityutskiy <dedekind@...radead.org>
To:	Hirofumi Nakagawa <hnakagawa@...aclelinux.com>
Cc:	christof.schmitt@...ibm.com, yoshfuji@...ux-ipv6.org,
	linux-mtd@...ts.infradead.org, linux-s390@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Remove duplicated unlikely() in IS_ERR()


On Fri, 2008-08-15 at 16:16 +0900, Hirofumi Nakagawa wrote:
> Hi
> Some drivers have duplicated unlikely() macros.
> IS_ERR() already has unlikely() in itself.
> This patch cleans up such pointless codes although there is no real
> effect on the kernel's behaviour.
> 
> Thanks,
> Hirofumi Nakagawa
> 
> Signed-off-by: Hirofumi Nakagawa <hnakagawa@...aclelinux.com>
> ---

Hmm, after thinking a bit I am not sure this is the right way to go.
Indeed, we try to avoid likly()/unlikely(), unless this is really
hot-path. Some kernel developers even think these hints should never
be used. So I'd say, the right thing would bo to remove unlikely()
from IS_ERR() macro instead.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html