netdev - Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver (Resend1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080823144040.08fcc322@speedy>
Date:	Sat, 23 Aug 2008 14:40:40 -0400
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Guo-Fu Tseng <cooldavid@...ldavid.org>
Cc:	Jeff Garzik <jgarzik@...ox.com>, Ethan <ethanhsiao@...cron.com>,
	akeemting <akeem@...cron.com>, netdev@...r.kernel.org
Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver
 (Resend1)

A couple of really minor things that could be changed (but don't have to).

> +struct jme_spi_op {
> +	void __user *uwbuf;
> +	void __user *urbuf;
> +	__u8	wn;	/* Number of write actions */
> +	__u8	rn;	/* Number of read actions */
> +	__u8	bitn;	/* Number of bits per action */
> +	__u8	spd;	/* The maxim acceptable speed of controller, in MHz.*/
> +	__u8	mode;	/* CPOL, CPHA, and Duplex mode of SPI */
> +
> +	/* Internal use only */
> +	__u8	*kwbuf;
> +	__u8	*krbuf;
> +	__u8	sr;
> +	__u16	halfclk; /* Half of clock cycle calculated from spd, in ns */
> +};


The conventional usage is to use __u8 for parameters that are being used in a kernel to
user ABI interface (like ioctl), and u8 for elements in a structure in a device driver.
Not sure why there is a distinction, but that is what I learne.

> --- netdev-2.6/include/linux/pci_ids.h	2008-08-22 07:48:54.000000000 +0800
> +++ linux/include/linux/pci_ids.h	2008-08-23 01:12:07.000000000 +0800
> @@ -2224,6 +2224,8 @@
>   #define PCI_DEVICE_ID_JMICRON_JMB38X_SD	0x2381
>   #define PCI_DEVICE_ID_JMICRON_JMB38X_MMC 0x2382
>   #define PCI_DEVICE_ID_JMICRON_JMB38X_MS	0x2383
> +#define PCI_DEVICE_ID_JMICRON_JMC250	0x0250
> +#define PCI_DEVICE_ID_JMICRON_JMC260	0x0260

Most device drivers no longer add entries to pci_ids.h for each device type. This used to
be done, but the file was getting too big and the id's only get used in one place.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html