netdev - Re: [PATCH 8/9] bnx2x: Multi Queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080825.153011.235553346.davem@davemloft.net>
Date:	Mon, 25 Aug 2008 15:30:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	netdev@...r.kernel.org, gertner@...adcom.com
Subject: Re: [PATCH 8/9] bnx2x: Multi Queue

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Mon, 25 Aug 2008 17:25:04 +0300

> The multi queue support is still disabled by default for the bnx2x
> (needs some more testing and validation), but there are 2 obvious bug in
> it which are fixed in this patch
> 
> Signed-off-by: Yitchak Gertner <gertner@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Applied, but this is a completely inappropriate change to be sending
at this time.  If multiqueue is disabled, then users absolutely cannot
hit any real bug due to these incorrect pieces of code.  Therefore it
is not fixing something that we should be trying to deal with outside
of the merge window.

Can I make a suggestion?  Instead of bombing me with 10 patches at a time,
is it possible to send a patch every day or so instead, as you write them?

That makes things enormously easier for me, because when I have to instead
bunch up several at a time I have to push this to Linus and all he sees
is lots of changes outside of the merge window all at once and I have to
explain to him why all of these changes are "really needed".

I know this probably doesn't mesh well with how you guys do development
and testing, but I hope you can see how it puts me into a corner as we
get deeper and deeper into the RC series. :(
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html