netdev - Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaprnwlogi.fsf@cisco.com>
Date:	Mon, 25 Aug 2008 15:27:57 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Scott Feldman <scofeldm@...co.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc

Overall, looks quite good.  Very clean, just a few comments here and there:

 > +#define PCI_VENDOR_ID_CISCO		0x1137
 > +#define PCI_DEVICE_ID_CISCO_ENIC	0x0043

the current convention is that we don't put IDs that are only used in
one place into pci_ids.h.  I guess the vendor ID can stay but the device
ID is probably not needed here (just put it in the driver file where
it's used, if anywhere).

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html