netdev - Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaiqtolo2i.fsf@cisco.com>
Date:	Mon, 25 Aug 2008 15:36:21 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Scott Feldman <scofeldm@...co.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 1/3] enic: add Makefile, patch Kconfg, MAINTAINERS, etc

Oh yeah, by the way, this patch got whitespace mangled somehow so it
won't apply (and also it seems to be against an old tree that doesn't
have the atl1e driver merged).

And:

 > +config ENIC
 > +	tristate "Cisco 10Gigabit Ethernet NIC"

The Kconfig file seems to use "10 Gigabit Ethernet" (with a space) or
variations on "10Gb Ethernet".  Probably worth it not to add yet another
variation.

 > +	depends on PCI
 > +	select INET_LRO

I believe if you select INET_LRO, you'd better depend on INET or else it
is possible to create unbuildable configs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html