netdev - Re: cat /proc/net/tcp takes 0.5 seconds on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080828.005909.215643947.davem@davemloft.net>
Date:	Thu, 28 Aug 2008 00:59:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	dada1@...mosbay.com, davej@...hat.com, netdev@...r.kernel.org,
	j.w.r.degoede@....nl
Subject: Re: cat /proc/net/tcp takes 0.5 seconds on x86_64

From: Andi Kleen <andi@...stfloor.org>
Date: Thu, 28 Aug 2008 09:45:36 +0200

> > When scanning route cache hash table, we can avoid taking locks for empty 
> > buckets.
> 
> I'm not sure it's worth it in this case.  A rcu_read_lock() is a nop
> (on non preemptible kernel) to very cheap (non atomic increment/decrement in 
> cached task_struct) 

It's not one, it's at least two such increments, plus function calls,
state checks, etc. since this is rcu_read_lock_bh().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html