[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48B65DDD.6020309@hhs.nl>
Date: Thu, 28 Aug 2008 10:12:13 +0200
From: Hans de Goede <j.w.r.degoede@....nl>
To: David Miller <davem@...emloft.net>
CC: andi@...stfloor.org, dada1@...mosbay.com, davej@...hat.com,
netdev@...r.kernel.org
Subject: Re: cat /proc/net/tcp takes 0.5 seconds on x86_64
David Miller wrote:
> From: Andi Kleen <andi@...stfloor.org>
> Date: Thu, 28 Aug 2008 09:45:36 +0200
>
>>> When scanning route cache hash table, we can avoid taking locks for empty
>>> buckets.
>> I'm not sure it's worth it in this case. A rcu_read_lock() is a nop
>> (on non preemptible kernel) to very cheap (non atomic increment/decrement in
>> cached task_struct)
>
> It's not one, it's at least two such increments, plus function calls,
> state checks, etc. since this is rcu_read_lock_bh().
>
I'm very happy to see some progress on this and this leading to even more
optimalizations elsewhere,
Thanks guys!
Regards,
Hans
p.s.
Can I please be removed from the CC, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists